-
-
Notifications
You must be signed in to change notification settings - Fork 9
Feat: Adding Linear Algebra Dot operation support #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Ahh forgot to update the general CI, or should we remove the |
Would the new functionality only be accessed through the dot function or is there a way to call that automatically when using numpy dot, matmul, etc? |
Unfortunately no, not easily. We'd need to add a new dtype hook to the DType API in NumPy. Worth doing though! See numpy/numpy#28516 which adds a hook for sorting. |
@ngoldbaum thoughts on this? |
Actually, I think we should probably not do this, unless And the first step, is to implement those ufuncs, I think. |
As per @seberg 's suggestion, this now implements Some extra stuff includes:
@ngoldbaum please take a look and let me know if anything needs a fix |
This PR contributes as follows:
dot
method within package that supports following operationsImages below are the performance comparison
To compile without QBLAS set
DISABLE_QUADBLAS
asCFLAGS
andCXXFLAGS